Some are running into undeclarated function errors:

> emacs/notmuch-tree.el:1143:1:Warning: the following functions are
>     not known to be defined: notmuch-search-previous-thread,
>     notmuch-search-next-thread, notmuch-tree-from-search-thread

Fixes: 874f14ec ("emacs/tree: enable moving to next thread in search results")
Reported-by: Danilo G. Baio <dbaio@FreeBSD.org>
Signed-off-by: William Casarin <jb55@jb55.com>
---

Hey there,

"Danilo G. Baio" <dbaio@FreeBSD.org> writes:
> Hi William.
>
> I'm updating notmuch on FreeBSD (to 0.31) and I'm getting this issue:
>
>
> ```
> [...]
> =======================<phase: stage          >============================
> ===>  Staging for notmuch-emacs27-0.31
> ===>   notmuch-emacs27-0.31 depends on executable: notmuch - found
> ===>   notmuch-emacs27-0.31 depends on file: /usr/local/bin/emacs-27.1 - found
> ===>   notmuch-emacs27-0.31 depends on executable: indexinfo - found
> ===>   Generating temporary packing list
> gmake[1]: Entering directory '/wrkdirs/usr/ports/mail/notmuch-emacs/work-full/notmuch-0.31'
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-compat.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-version.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-lib.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-parser.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-tag.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-query.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/coolj.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-wash.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-company.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-address.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-maildir-fcc.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-draft.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-message.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-mua.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-crypto.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-print.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-show.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-hello.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-jump.el
> /usr/local/bin/emacs-27.1 --directory emacs -batch -f batch-byte-compile emacs/notmuch-tree.el
>
> In end of data:
> emacs/notmuch-tree.el:1143:1:Warning: the following functions are not known to
>     be defined: notmuch-search-previous-thread, notmuch-search-next-thread,
>     notmuch-tree-from-search-thread
>
> [...]
> ```
>
> I don't use Emacs and don't have a clue in how fix this.
>
> Could you help me?
>
> Regards.
> -- 
> Danilo G. Baio (dbaio)

I got this report from user with the new notmuch-tree updates. I didn't
run into this, but it looks like these functions are supposed to be
forwardly declared first? 

I don't have a way of testing this and I'm waiting to see if it fixes
their issue, but thought I'd would post the patch here as well for
review.

Cheers,
Will

emacs/notmuch-tree.el | 3 +++
1 file changed, 3 insertions(+)

diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
index f342f85a..3336139e 100644
--- a/emacs/notmuch-tree.el
+++ b/emacs/notmuch-tree.el
@@ -41,6 +41,9 @@
 (declare-function notmuch-read-query "notmuch" (prompt))
 (declare-function notmuch-search-find-thread-id "notmuch" (&optional bare))
 (declare-function notmuch-search-find-subject "notmuch" ())
+(declare-function notmuch-search-next-thread "notmuch" ())
+(declare-function notmuch-search-previous-thread "notmuch" ())
+(declare-function notmuch-tree-from-search-thread "notmuch" ())
 
 ;; the following variable is defined in notmuch.el
 (defvar notmuch-search-query-string)
-- 
2.28.0
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org