[PATCH 01/11] lib: add regression test for n_m_get_date; clarify API

Subject: [PATCH 01/11] lib: add regression test for n_m_get_date; clarify API

Date: Sun, 5 Jul 2020 10:00:16 -0300

To: notmuch@notmuchmail.org

Cc: David Bremner

From: David Bremner

This function catches Xapian exceptions. The test is intended to make
sure it stays that way.
---
 lib/notmuch.h          |  2 ++
 test/T560-lib-error.sh | 16 ++++++++++++++++
 2 files changed, 18 insertions(+)

diff --git a/lib/notmuch.h b/lib/notmuch.h
index c7b21060..b7de7652 100644
--- a/lib/notmuch.h
+++ b/lib/notmuch.h
@@ -1528,6 +1528,8 @@ notmuch_message_set_flag (notmuch_message_t *message,
  * For the original textual representation of the Date header from the
  * message call notmuch_message_get_header() with a header value of
  * "date".
+ *
+ * Returns 0 in case of error.
  */
 time_t
 notmuch_message_get_date (notmuch_message_t *message);
diff --git a/test/T560-lib-error.sh b/test/T560-lib-error.sh
index 06b43ef2..ab7a24d1 100755
--- a/test/T560-lib-error.sh
+++ b/test/T560-lib-error.sh
@@ -470,5 +470,21 @@ cat <<EOF > EXPECTED
 EOF
 test_expect_equal_file EXPECTED OUTPUT
 
+test_begin_subtest "Handle getting date from closed database"
+cat c_head2 - c_tail <<'EOF' | test_C ${MAIL_DIR}
+    {
+        time_t result;
+        result = notmuch_message_get_date (message);
+        printf("%d\n%d\n", message != NULL, result == 0);
+    }
+EOF
+cat <<EOF > EXPECTED
+== stdout ==
+1
+1
+== stderr ==
+EOF
+test_expect_equal_file EXPECTED OUTPUT
+
 
 test_done
-- 
2.27.0
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: