Re: [PATCH] lib: return "" rather than NULL from notmuch_thread_get_authors

Subject: Re: [PATCH] lib: return "" rather than NULL from notmuch_thread_get_authors

Date: Sat, 16 Dec 2017 07:54:02 +1000

To: David Bremner

Cc: notmuch@notmuchmail.org

From: Róman Joost


Dear David,

On Thu, Dec 14, 2017 at 10:29:57PM -0400, David Bremner wrote:
> The current beheviour is at best underdocumented. The modified test in
> T470-missing-headers.sh previously relied on printf doing the right
> thing with NULL, which seems ick.
> 
> The use of talloc_strdup here is probably overkill, but it avoids
> having to enforce that thread->authors is never mutated outside
> _resolve_thread_authors_string.
> [...]

Thanks a lot for this patch. I think it'll help future authors to be
less surprised :))

Kind Regards,
-- 
Róman Joost
email: roman@bromeco.de
GPG key: 3A765B52
signature.asc (application/pgp-signature)
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: