Re: [PATCH] Add option `hooks.path` for setting the directory of hooks.

Subject: Re: [PATCH] Add option `hooks.path` for setting the directory of hooks.

Date: Tue, 30 Aug 2016 10:49:11 +0200

To: Tomi Ollila

Cc: Jani Nikula,, David Bremner

From: Erik Rybakken

On Tue, Aug 30, 2016 at 08:43:20AM +0300, Tomi Ollila wrote:
> The code looked pretty good -- when did I git am to the email content
> I got all from the beginning of this email to the commit message --
> so before next patches use git-format-patch and git-am... Check
> for more information...

Sorry about that. I will start checking my email patches.

> 2 things that came up after quick view
> 1) there is one indentation mismatch ;/

I'm not sure what you refer to here. Could you point me to it?

> 3) I don't see any calls to notmuch_config_set_hooks_path()

Yes, that's true. The function is not needed now, but I kept it for

So, there are only two places in the code where there are calls to
notmuch_config_set_*. One of them are in the procedure
"notmuch_config_open" in notmuch-config.c where the config file is read.
For hooks_path the reading is done differently as explained in the last

The other place is in notmuch-setup.c, but the notmuch setup does not
(for now) set hooks.path.

The command "notmuch config set" does not use notmuch_config_set for
some reason, but changes the key file directly.

- Erik