Re: [PATCH v3] nmbug: Add an 'init' command

Subject: Re: [PATCH v3] nmbug: Add an 'init' command

Date: Sat, 29 Nov 2014 12:09:17 -0800

To: Michal Sojka

Cc: notmuch@notmuchmail.org

From: W. Trevor King


On Sat, Nov 29, 2014 at 10:40:01AM +0100, Michal Sojka wrote:
> On Út, říj 28 2014, W. Trevor King wrote:
> > +        _spawn(
> > +            args=['git', 'init', '--separate-git-dir', NMBGIT, workdir],
> > +            wait=True)
> > +        _git(args=['config', '--unset', 'core.worktree'], wait=True)
> > +        _git(args=['config', 'core.bare', 'true'], wait=True)
> 
> Why do you create a non-bare repository and then make it bare?

Bare repositories don't usually have upstream tracking branches.  See
the commit message for c2001674 (nmbug: Add 'clone' and replace
FETCH_HEAD with @{upstream}, 2014-03-09) for details [1].  I can
resubmit this patch with a commit message that mentions the
explanation in c2001674 if folks want the extra clarity here.

Cheers,
Trevor

[1]: id:de7dd9d4021cd17350df4423bc13f3da35f2b324.1394410765.git.wking@tremily.us
     http://thread.gmane.org/gmane.mail.notmuch.general/17457

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
signature.asc (application/pgp-signature)

Thread: