Re: [PATCH 0/5] nmbug-status fixups from notmuch-to-html

Subject: Re: [PATCH 0/5] nmbug-status fixups from notmuch-to-html

Date: Sun, 11 May 2014 17:36:43 -0700

To: Carl Worth

Cc: notmuch@notmuchmail.org

From: W. Trevor King


On Sun, May 11, 2014 at 12:04:12PM -0700, Carl Worth wrote:
> "W. Trevor King" <wking@tremily.us> writes:
> > I've cherry-picked the three patches I liked from Carl's master [1,2]
> > and added two cleanup commits of my own.  I've left Carl's commit
> > messages unchanged.  I'm fine squashing my fixups into Carl's
> > originals (leaving Carl as the author) if that's ok with him.
> 
> Please feel free to do whatever you like with any of these.

Thanks :).  If folks do want a reroll, I think the following squash
groups make sense:

* Move the generated date from the top of the page to the footer
* nmbug-status: Use a triple-quoted string for the footer template
* nmbug-status: Make the footer's <hr> gray

* Add a comment describing the program
* nmbug-status: Shift the script description into a docstring

I'll wait another week or so for additional feedback on v1, and then
squash and submit v2.

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
signature.asc (application/pgp-signature)

Thread: