Re: [PATCH] replace gnu xargs usage in notmuch-mutt with perl

Subject: Re: [PATCH] replace gnu xargs usage in notmuch-mutt with perl

Date: Tue, 10 Apr 2012 10:25:52 +0200

To: Taylor Carpenter

Cc: notmuch@notmuchmail.org

From: Stefano Zacchiroli


Hi Taylor, thanks for your patch. It makes sense to me, and has the
beneficial side effect of avoiding a sed pass to do some poor men shell
escaping.

Before applying, however, can you please update it to:

- include a reasonable comment (as suggested by David)
- avoid patching the shebang line (ditto)
- coalesce the sprintf() line into the following symlink line (using
  sprintf seems redundant here: it's plain string concatenation)

Thanks!
Cheers.

PS please Cc:-me on replies
-- 
Stefano Zacchiroli     zack@{upsilon.cc,pps.jussieu.fr,debian.org} . o .
Maître de conférences   ......   http://upsilon.cc/zack   ......   . . o
Debian Project Leader    .......   @zack on identi.ca   .......    o o o
« the first rule of tautology club is the first rule of tautology club »

Thread: