Re: [PATCH v3 0/4] cli: notmuch tag/restore refactoring

Subject: Re: [PATCH v3 0/4] cli: notmuch tag/restore refactoring

Date: Thu, 29 Mar 2012 01:59:17 -0400

To: Jani Nikula

Cc: tomi.ollila@iki.fi, notmuch@notmuchmail.org

From: Austin Clements


Quoth Jani Nikula on Mar 27 at 12:04 am:
> v3 of id:"cover.1332702915.git.jani@nikula.org" with the following
> mostly non-functional changes:
> 
>  - add test for the current tagging behaviour in patch 1, and change the
>    test in patch 2 when the behaviour is changed
>  - handle the no tag changes case in _optimize_tag_query() in patch 2
>  - add braces around the "tag_ops[tag_ops_count].remove = (argv[i][0] == '-');"
>    assignment
>  - document the tag_query() function a bit in patch 3
>  - make tag_message() static in patch 4
> 
> BR,
> Jani.

LGTM.

Thread: