Re: [PATCH] Actually close the xapian database in notmuch_database_close

Subject: Re: [PATCH] Actually close the xapian database in notmuch_database_close

Date: Thu, 1 Mar 2012 21:20:41 +0000

To: Justus Winter

Cc: notmuch@notmuchmail.org

From: Olly Betts

On Thu, Mar 01, 2012 at 07:59:30AM +0100, Justus Winter wrote:
> Olly wrote:
> >It is hard to say if calling close() is actually useful here from just
> >seeing the patch.
> 
> Huh? I provided a test case...

I only saw the part of the patch Austin quoted in the mail he cc-ed to
me.

> Quoting Austin Clements (2012-02-29 23:17:54)
> >Also, since close could throw an exception, it should get wrapped in a
> >try/catch like flush currently is.
> 
> My interpretation of [0] was that Xapian::Database::close() does not
> throw any exceptions.

Sadly there's not full documentation of exceptions which can be thrown 
by a particular method.

Cheers,
    Olly

Thread: