Re: [PATCH 5/7] py3k: the basestring and unicode types are removed in python 3

Subject: Re: [PATCH 5/7] py3k: the basestring and unicode types are removed in python 3

Date: Sun, 08 Jan 2012 14:04:44 -0000

To: Tomi Ollila, Sebastian Spaeth, notmuch@notmuchmail.org

Cc:

From: Justus Winter


Hi Tomi, Hi Sebastian :)

Quoting Tomi Ollila (2012-01-04 19:07:11)
>On Mon, 02 Jan 2012 16:15:58 +0100, Sebastian Spaeth <Sebastian@SSpaeth.de> wrote:
>> Happy new year. Pushed patches 1-4 of this series so far. Looking fine,

nice, thanks.

>> but ugh, the below seems like a rather ugly hack in a function that is
>> probably called quite often.
>>
>> Isn't there a more pretty variant avoiding these sys.version_info checks
>> all over the place?

Well, I rebased and updated this patch. There are now two different
implementations of _str like there are two Python3StringMixIn
classes. I'll send this patch as reply to this message.

>Does the Python3StringMixIn stuff in later patches already handle this
>patch -- and making this obsolete ?

No, that only handles the __str__ and __unicode__ stuff.

Cheers,
Justus

Thread: