Re: [notmuch] [PATCH] notmuch-new: Option to disable tags from the configuration file.

Subject: Re: [notmuch] [PATCH] notmuch-new: Option to disable tags from the configuration file.

Date: Wed, 25 Nov 2009 14:55:20 -0500

Jan,

I think your use of STRNCMP_LITERAL here is wrong...

> +	} else if (STRNCMP_LITERAL (argv[i], "--no-config-tags") == 0) {
> +	    add_config_tags = 0;

it will happily match "--no-config-tags-xxxxxxxxxxxxxxxxxxx".

Can I also suggest including --no-config-tags in the 'notmuch help'
output?

Besides that I am very happy with this patch series.

-pBart

-- 
				WebSig: http://www.jukie.net/~bart/sig/

Previous message (by thread): Re: [notmuch] [PATCH 0/4] Make tags applied by 'notmuch new' configurable.

Thread:

Jan Janak—[notmuch] [PATCH 0/4] Make tags applied by 'notmuch new' configurable. [inbox, unread]
- Jan Janak—[notmuch] [PATCH 1/4] notmuch-new: Remove tag_add_inbox_unread in favor of a generic solution. [inbox, unread]
  - Jan Janak—[notmuch] [PATCH 2/4] notmuch: Config option to specify tags to be applied by 'notmuch new'. [inbox, unread]
    - Jan Janak—[notmuch] [PATCH 3/4] notmuch-setup: Copy/create the new section with tags for 'notmuch-new'. [inbox, unread]
      - Jan Janak—[notmuch] [PATCH 4/4] notmuch-new: New cmdline option --tag=<name>. [inbox, unread]
        Karl Wiberg—Re: [notmuch] [PATCH 4/4] notmuch-new: New cmdline option --tag=<name>. [inbox, unread]
        Jan Janak—Re: [notmuch] [PATCH 4/4] notmuch-new: New cmdline option --tag=<name>. [inbox, unread]
        Jan Janak—[notmuch] [PATCH] notmuch-new: Option to disable tags from the configuration file. [inbox, unread]
        Bart Trojanowski—Re: [notmuch] [PATCH] notmuch-new: Option to disable tags from the configuration file. [inbox, unread]
        Jan Janak—Re: [notmuch] [PATCH] notmuch-new: Option to disable tags from the configuration file. [inbox, unread]
    - Bart Trojanowski—Re: [notmuch] [PATCH 2/4] notmuch: Config option to specify tags to be applied by 'notmuch new'. [inbox, unread]
      - Jan Janak—Re: [notmuch] [PATCH 2/4] notmuch: Config option to specify tags to be applied by 'notmuch new'. [inbox, unread]
        Carl Worth—Re: [notmuch] [PATCH 2/4] notmuch: Config option to specify tags to be applied by 'notmuch new'. [inbox, signed, unread]
- Brett Viren—Re: [notmuch] [PATCH 0/4] Make tags applied by 'notmuch new' configurable. [inbox, unread]
- Bdale Garbee—Re: [notmuch] [PATCH 0/4] Make tags applied by 'notmuch new' configurable. [inbox, unread]
- Bart Trojanowski—Re: [notmuch] [PATCH 0/4] Make tags applied by 'notmuch new' configurable. [inbox, unread]
- Jan Janak—[notmuch] [PATCH 1/5] notmuch-new: Remove tag_add_inbox_unread in favor of a generic solution. [inbox, unread]
  - Jan Janak—[notmuch] [PATCH 2/5] notmuch: Config option to specify tags to be applied by 'notmuch new'. [inbox, unread]
    - Jan Janak—[notmuch] [PATCH 3/5] notmuch-setup: Copy/create the new section with tags for 'notmuch-new'. [inbox, unread]
      - Jan Janak—[notmuch] [PATCH 4/5] notmuch-new: New cmdline option --tag=<name>. [inbox, unread]
        Jan Janak—[notmuch] [PATCH 5/5] notmuch-new: Option to disable tags from the configuration file. [inbox, unread]
- Jan Janak—Re: [notmuch] [PATCH 0/4] Make tags applied by 'notmuch new' configurable. [inbox, unread]
- Carl Worth—Re: [notmuch] [PATCH 0/4] Make tags applied by 'notmuch new' configurable. [inbox, signed, unread]
  - Marten Veldthuis—Re: [notmuch] [PATCH 0/4] Make tags applied by 'notmuch new' configurable. [inbox, unread]
    - Carl Worth—Re: [notmuch] [PATCH 0/4] Make tags applied by 'notmuch new' configurable. [inbox, signed, unread]