On Mon, Nov 23, 2009 at 04:41:23PM +0100, Ingmar Vanhassel wrote: > Excerpts from Brett Viren's message of Mon Nov 23 16:31:47 +0100 2009: > > Installing as a normal user fails because the bash completion config > > files try to install into /etc. This trivial patch fixes this. > > Your patch breaks the more common case of installing as root user. It > now installs into /usr/etc where bash completions most likely won't be > found. I submitted a patch similar to Ingmar's the other day. I actually feel like the more common case is to install it locally as a local user, especially during early development. jamie. > > diff --git a/Makefile.config b/Makefile.config > > index ddc7436..c04d57a 100644 > > --- a/Makefile.config > > +++ b/Makefile.config > > @@ -1,3 +1,2 @@ > > -prefix = /usr/local > > -bash_completion_dir = /etc/bash_completion.d > > +bash_completion_dir = $(prefix)/etc/bash_completion.d > > CFLAGS += -DHAVE_VALGRIND > > > > > > -Brett. > -- > Exherbo KDE, X.org maintainer > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch