Re: [PATCH v5 0/6] indexing attachment contents

Subject: Re: [PATCH v5 0/6] indexing attachment contents

Date: Sun, 16 Aug 2026 18:21:10 +0200

To: notmuch@notmuchmail.org, David Bremner

Cc:

From: Anton Khirnov


Quoting David Bremner (2026-08-16 14:29:58)
> Anton Khirnov <anton@khirnov.net> writes:
> 
> > Hi,
> > another iteration of the set adding support for indexing attachment
> > contents. I believe I've addressed all the review comments from the
> > previous round [1].
> >
> > The first patch now contains a simple performance test that runs reindex
> > on all emails with attachments - twice with no filter, and once with a
> > trivial /bin/true filter. By placing the test early in the series it is
> > easy to see that the following patches do not make the filter-less runs
> > slower.
> 
> I have applied v5.1 (with your updated patch 4) to master. I realized
> while doing my final checks that there were some whitespace
> disagreements with uncrustify. Rather than doing another round I just
> amended the patches.

Awesome. Thank you for all your help with this.

Cheers,
-- 
Anton Khirnov
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: