David Bremner venit, vidit, dixit 2021-05-12 14:07:33: > David Bremner <david@tethera.net> writes: > > > David Bremner <david@tethera.net> writes: > > > >> In some uses of reopen, new documents and threads maybe have been > >> added, and e.g. compaction may have changed the uuid. > > > > It's quite possible there is more cached data that should be discarded, > > but I'll have to think about that a bit more. > > > > The following are at least potential problems, although I think none of > them are as urgent as the doc_id / thread_id issue. > > exception_reported should probably be reset to false > > atomic_nesting, atomic_dirty. Re-opening while in an open atomic > section is currently undefined > behaviour, should be checked. > > features Theoretically if the user runs notmuch-new in a pre-new hook, > the database could be upgraded. For now, I suggest not doing > that. This should be fixabable, but I prefer to take more time. Out of curiosity: What does reopening gain compared to a full close/open cycle? Michael _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-leave@notmuchmail.org