Re: [RFC patch 2/2] lib: handle DatabaseModifiedError in _n_message_ensure_metadata

Subject: Re: [RFC patch 2/2] lib: handle DatabaseModifiedError in _n_message_ensure_metadata

Date: Fri, 24 Feb 2017 10:21:06 +0000

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Gaute Hope

David Bremner writes on februar 24, 2017 3:49:
> David Bremner <david@tethera.net> writes:
> 
>> The error handling here still needs work. The retry count should be
>> handled in more sane way, and both running out of retries and an error
>> return from notmuch_database_reopen should be handled.
> 
> Probably the number of retries can be limited to 1, since afaict, reopen
> is not going to return any recoverable errors.

Does _reopen block if the db is locked?

• Previous message (by thread): Re: [RFC patch 2/2] lib: handle DatabaseModifiedError in _n_message_ensure_metadata

Thread:

• David Bremner—add status value to _notmuch_message_ensure_metadata [inbox, unread]
  • David Bremner—[PATCH 1/8] lib: make _notmuch_message_ensure_metadata static [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
    • David Bremner—Re: [PATCH 1/8] lib: make _notmuch_message_ensure_metadata static [inbox, unread]
  • David Bremner—[PATCH 2/8] lib: add status return to _notmuch_message_ensure_metadata [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 3/8] lib: propagate error return from some calls to _n_m_e_metadata [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 4/8] lib: push error from nme_metadata through nme_filename_list [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 5/8] lib: make _notmuch_message_ensure_property_map static [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  • David Bremner—[PATCH 6/8] lib: propagate errors from nme_metadata through properties API [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 7/8] lib: add notmuch_message_get_database to public API [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Bremner—[PATCH 8/8] lib: add status return to notmuch_message_get_flag [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Gaute Hope—Re: add status value to _notmuch_message_ensure_metadata [inbox, unread]
    • Gaute Hope—Re: add status value to _notmuch_message_ensure_metadata [attachment, inbox, signed, unread]
      • David Bremner—Re: add status value to _notmuch_message_ensure_metadata [inbox, unread]
        • Gaute Hope—Re: add status value to _notmuch_message_ensure_metadata [inbox, unread]
          • David Bremner—Re: add status value to _notmuch_message_ensure_metadata [inbox, unread]
            • David Bremner—[RFC patch 1/2] lib: add notmuch_database_reopen [inbox, notmuch::obsolete, notmuch::patch, unread]
              • David Bremner—[RFC patch 2/2] lib: handle DatabaseModifiedError in _n_message_ensure_metadata [inbox, notmuch::obsolete, notmuch::patch, unread]
                • David Bremner—Re: [RFC patch 2/2] lib: handle DatabaseModifiedError in _n_message_ensure_metadata [inbox, unread]
                  • Gaute Hope—Re: [RFC patch 2/2] lib: handle DatabaseModifiedError in _n_message_ensure_metadata [inbox, unread]
                    • David Bremner—Re: [RFC patch 2/2] lib: handle DatabaseModifiedError in _n_message_ensure_metadata [inbox, unread]