While passing a lambda to mapc is idiomatic elisp, dolist is easier to understand, and there are a few other calls to it in this file. --- emacs/notmuch.el | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 43d56f7..6307b37 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -700,13 +700,12 @@ background." (defun notmuch-search-color-line (start end line-tag-list) "Colorize lines in `notmuch-show' based on tags." - (mapc (lambda (elem) - (let ((tag (car elem)) - (attributes (cdr elem))) - (when (member tag line-tag-list) - (notmuch-apply-face nil attributes nil start end)))) - ;; Reverse the list so earlier entries take precedence - (reverse notmuch-search-line-faces))) + ;; Reverse the list so earlier entries take precedence + (dolist (elem (reverse notmuch-search-line-faces)) + (let ((tag (car elem)) + (face (cdr elem))) + (when (member tag line-tag-list) + (notmuch-apply-face nil face nil start end))))) (defun notmuch-search-author-propertize (authors) "Split `authors' into matching and non-matching authors and -- 2.8.0.rc3.226.g39d4020