Re: [PATCH] WIP: regexp matching in 'subject' and 'from'

Subject: Re: [PATCH] WIP: regexp matching in 'subject' and 'from'

Date: Sat, 11 Jun 2016 16:32:14 +0000

To: David Bremner, Austin Clements

Cc: sfischme@uwaterloo.ca, notmuch

From: Gaute Hope


David Bremner writes on juni 10, 2016 13:09:
> Gaute Hope <eg@gaute.vetsj.com> writes:
> 
>>
>> Cool!
>>
>> Would it break a lot of things if you just replace the original prefix?
> 
> It would change the matching behaviour. I guess there are people that
> like the current "sloppy" matching of from: and subject:.  In my
> not-very-scientific tests, it is a factor of 5 to 10 times slower to do
> regexp search, which makes sense because it is effectively post
> processing the results from Xapian. At least on my system it seems fast
> enough to be usable interactively, but that is a pretty shocking
> performance regression. And I know there are people with more mail on
> slower systems.

Maybe we could check if the search string contains a regexp and decide
whether to pre-process it on the background of that? I think that would
make the interface more user-friendly. You'd just always use search
whether you decide that you need to put in some regexp or not.

> 
>> Could it be made to work on the message body?
> 
> See Austin's previous reply for the details, but basically no; these
> "values" index in terms of whole strings, while the body is indexed by
> terms (roughly, words). In principle we could add a value slot for the
> body, but I think that would at least double the size of the database
> (maybe more).
> 

I would rather have double the db and be able wildcard beginning of
terms. If it is not too much maintaining overhead it might be made
optional?


Regards, Gaute


Thread: