[RFC PATCH] emacs: show: make show-get-message-prop usable from pick

Subject: [RFC PATCH] emacs: show: make show-get-message-prop usable from pick

Date: Sun, 2 Dec 2012 21:29:04 +0000

To: notmuch@notmuchmail.org

Cc:

From: Mark Walters

Make notmuch-show-get-prop choose the get-message-properties routine
based on the major mode. This make it usable from notmuch-pick and
thus a large number of functions are usable directly from
notmuch-show.el and do not need to be reimplemented in pick.
---

With this change (and a corresponding very small change in pick) I can
use a large number of functions straight from show in pick-mode. The
only change they need is that when they get a message property (most
commonly the message-id) they use the correct routine. This makes the
choice of the routine based on the major-mode.

It seems to work and could save quite a lot of code being essentially
duplicated. Would something like this be acceptable? Would it be way
too slow? Is there some much better way? Any comments (including "Just
don't do that") gratefully received.

Best wishes

Mark



 emacs/notmuch-show.el |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 4d6c014..3e68871 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1378,6 +1378,10 @@ Some useful entries are:
     (notmuch-show-move-to-message-top)
     (get-text-property (point) :notmuch-message-properties)))
 
+(defun notmuch-show-mode-get-message-properties ()
+  "Wrapper for notmuch-show-get-message-properties"
+  (notmuch-show-get-message-properties))
+
 (defun notmuch-show-set-prop (prop val &optional props)
   (let ((inhibit-read-only t)
 	(props (or props
@@ -1387,7 +1391,8 @@ Some useful entries are:
 
 (defun notmuch-show-get-prop (prop &optional props)
   (let ((props (or props
-		   (notmuch-show-get-message-properties))))
+		   (funcall (intern (concat (symbol-name major-mode)
+					    "-get-message-properties"))))))
     (plist-get props prop)))
 
 (defun notmuch-show-get-message-id (&optional bare)
-- 
1.7.9.1

Thread: