[PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error

Subject: [PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error

Date: Sun, 21 Oct 2012 15:58:56 +0300

To: notmuch@notmuchmail.org

Cc: tomi.ollila@iki.fi

From: Tomi Ollila


When inserting of email bodypart failes, insert a failure message
to the buffer (and continue) instead of halting the insertion of
the rest of that email thread in question.
---

The failure of inserting bodyparts can be experienced in thread
starting with 

id:"m31ul3qo4w.fsf@quad.robs.office"

the email id:"87d31artti.fsf@inf-8657.int-evry.fr"
makes the halt happen -- when this patch is applied
the message !!! bodypart insertion error !!! appears in the
buffer.

for example the email id:"87mwzgxq5l.fsf@inf-8657.int-evry.fr"

is not shown in that thread until this patch is applied.

Whenever everyone can read these emails we can try to figure
out why id:"1349333712-18347-1-git-send-email-tomi.ollila@iki.fi"
did not fix some calendar bodypart for Olivier.

Tomi

 emacs/notmuch-show.el |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index f273eb4..651a5ee 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -815,7 +815,9 @@ message at DEPTH in the current thread."
     ;; Run the content handlers until one of them returns a non-nil
     ;; value.
     (while (and handlers
-		(not (funcall (car handlers) msg part content-type nth depth declared-type)))
+		(not (condition-case nil
+			 (funcall (car handlers) msg part content-type nth depth declared-type)
+		       (error (progn (insert "!!! bodypart insert error !!!\n") nil)))))
       (setq handlers (cdr handlers))))
   t)
 
-- 
1.7.1


Thread: