Re: [PATCH] Build symbol-test with make a not manually in symbol-hiding.

Subject: Re: [PATCH] Build symbol-test with make a not manually in symbol-hiding.

Date: Fri, 25 Nov 2011 11:03:05 +0100

To: notmuch

Cc:

From: Amadeusz Żołnowski


Excerpts from Amadeusz Żołnowski's message of 2011-11-25 10:52:16 +0100:
> Fixed warnings in symbol-test.cc, btw.

I forgot to add: why.  If symbol-test is built in symbol-hiding with
hardcoded g++ invokation, it's not so easy to pass $(srcdir) which is
required to find notmuch.h when srcdir and builddir are separate
directories.  When moved building to Makefile, it works fine.

PS.
"[PATCH] Build symbol-test with make a not manually in symbol-hiding."
                                     ^--- it should be "and" or ", "

-- 
Amadeusz Żołnowski
signature.asc (application/pgp-signature)

Thread: