[PATCH 00/10] Fix 'notmuch new' atomicity issues

Subject: [PATCH 00/10] Fix 'notmuch new' atomicity issues

Date: Fri, 18 Feb 2011 02:58:50 -0500

To: notmuch@notmuchmail.org

Cc: amdragon@mit.edu

From: Austin Clements

This patch series modifies notmuch new to perform all operations
atomically and to perform maildir flag synchronization eagerly.  As a
result, notmuch new can be interrupted without risking database
consistency or losing track of messages, but still without losing
progress in the middle of a big import.  This also paves the way for
fixing the antisocial locking behavior of notmuch new.

While there are quite a few patches in the series, each one is
bite-sized and you can see the number of atomicity violations dropping
with nearly every patch using the test added by the first patch.

On my test machine, these patches have no affect on performance.

These patches are also available on the atomic-new-v1 branch at
 http://awakening.csail.mit.edu/git/notmuch.git/

• Previous message (by thread): Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues

Thread:

• Austin Clements—[PATCH 00/10] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
  • Austin Clements—[PATCH 01/10] test: Test atomicity of notmuch new. [inbox, notmuch::pushed, unread]
    • Austin Clements—[PATCH 01/10 v2] test: Test atomicity of notmuch new. [inbox, notmuch::pushed, unread]
  • Austin Clements—[PATCH 02/10] new: Don't loose messages on SIGINT. [inbox, notmuch::pushed, unread]
  • Austin Clements—[PATCH 03/10] new: Defer updating directory mtimes until the end. [inbox, notmuch::pushed, unread]
  • Austin Clements—[PATCH 04/10] lib: Make _notmuch_message_sync capable of deleting a message. [inbox, notmuch::pushed, unread]
  • Austin Clements—[PATCH 05/10] lib: Indicate if there are more filenames after removal. [inbox, notmuch::pushed, unread]
  • Austin Clements—[PATCH 06/10] lib: Add API's to find by filename and remove a filename from a message. [inbox, notmuch::pushed, unread]
  • Austin Clements—[PATCH 07/10] new: Use the new filename removal API. [inbox, notmuch::pushed, unread]
  • Austin Clements—[PATCH 08/10] new: Synchronize maildir flags eagerly. [inbox, notmuch::pushed, unread]
  • Austin Clements—[PATCH 09/10] lib: Add notmuch_database_{begin,end}_atomic. [inbox, notmuch::pushed, unread]
  • Austin Clements—[PATCH 10/10] new: Wrap adding a message in an atomic section. [inbox, notmuch::pushed, unread]
  • Austin Clements—Re: [PATCH 00/10] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
    • Austin Clements—Re: [PATCH 00/10] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
      • Austin Clements—Re: [PATCH 00/10] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
        • Carl Worth—Re: [PATCH 00/10] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, signed, unread]
          • Austin Clements—Re: [PATCH 00/10] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
            • Carl Worth—Re: [PATCH 00/10] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, signed, unread]
              • Austin Clements—Re: [PATCH 00/10] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
          • Austin Clements—[PATCH v6 00/17] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 02/17] test: Report test failures from test_expect_* [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 03/17] lib: Add missing status check in _notmuch_message_remove_filename. [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 04/17] test: Test atomicity of notmuch new. [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 05/17] new: Don't lose messages on SIGINT. [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 06/17] new: Defer updating directory mtimes until the end. [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 07/17] lib: Add notmuch_database_{begin,end}_atomic. [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 08/17] lib: Add support for nested atomic sections. [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 09/17] lib: Indicate if there are more filenames after removal. [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 10/17] lib: Remove message document directly after removing the last file name. [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 11/17] lib: Add an API to find a message by filename. [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 12/17] lib: Wrap notmuch_database_add_message in an atomic section. [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 13/17] new: Cleanup. Put removed/renamed message count in add_files_state_t. [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 14/17] new: Cleanup. De-duplicate file name removal code. [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 15/17] new: Synchronize maildir flags eagerly. [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 16/17] new: Wrap adding and removing messages in atomic sections. [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 17/17] lib: Improve notmuch_database_{add, remove}_message documentation. [inbox, notmuch::pushed, unread]
            • Austin Clements—[PATCH 01/17] test: Fix message when skipping test_expect_equal* tests [inbox, notmuch::pushed, unread]
            • Austin Clements—Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
            • Austin Clements—Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
              • Austin Clements—Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
              • Austin Clements—Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
                • David Bremner—Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
                  • David Bremner—Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
                    • Austin Clements—Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
                      • David Bremner—Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
                        • Austin Clements—Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
                          • David Bremner—NEWS for 0.9 [inbox, notmuch::pushed, unread]
                            • Ali Polatel—Re: NEWS for 0.9 [inbox, notmuch::pushed, signed, unread]
            • Sebastian Spaeth—Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, signed, unread]
              • Austin Clements—Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, unread]
                • Sebastian Spaeth—Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues [inbox, notmuch::pushed, signed, unread]