> Just now I don't have more time to comment and review more, but in the > first 2/3 patches when I tried to compile I got problem NULL not > defined. Oh! Yes, I should include <stdio.h> to pull in the definition of NULL. I'll fix that. > Another thing: you have this > > +# Whether the asctime_r function is standards-compliant > +# (if not, then notmuch will compile with -D_POSIX_PTHREAD_SEMANTICS > +# to enable the standards-compliant version -- needed for Solaris) > > which is not exactly so.. you added the following lines in compat.h > > +#if !STD_GETPWUID > +#define _POSIX_PTHREAD_SEMANTICS > +#endif > > which is slightly different as -D_POSIX_PTHREAD_SEMANTICS is equivalent to > #define _POSIX_PTHREAD_SEMANTICS 1 > > (you probably knew this and your comments have drifted from actual > implementation but just to make sure) I'll make the code and comment line up better. Thanks for your comments. Blake