RE: Reply all - issue

Subject: RE: Reply all - issue

Date: Wed, 30 Jan 2013 22:49:31 +0100

To: 'Carl Worth', 'Jani Nikula', notmuch@notmuchmail.org

Cc:

From: Robert Mast


I ran git send-email and became the following line in the mail-header:

"X-Mailer: git-send-email 1.7.9.5"

I see that this git-marker already existed in version 1.3 in 2006:

http://comments.gmane.org/gmane.comp.version-control.git/23337 

Can I assume, apart from the version number, that this header-marker applies
to all git-mail that should not be subject-splitted?

I can also leave the threads in the database as they are and only change
notmuch_query_search_threads in lib/query.cc to add the subject as a second
hash-key and notmuch_threads_get/_notmuch_thread_create for also looking for
the subject of the seed-message.

Then I only have to add the stripped subject as a search-term. The subject
that's now in the database is the original non-stripped subject.

I expect next weekend to have some time again.

-----Oorspronkelijk bericht-----
Van: Robert Mast [mailto:beheerder@tekenbeetziekten.nl] 
Verzonden: woensdag 30 januari 2013 21:57
Aan: 'Carl Worth'; 'Jani Nikula'; 'notmuch@notmuchmail.org'
Onderwerp: RE: Reply all - issue

I never used git for mailpatching, so I have no example-mailbox to analyse.

I understand that the subject starting with "[PATCH <anything>]" can be a
git-hint, but is not guaranteed. Or is it? [1]

If it isn't, can I assume all git-messages comply to this set: [2]

"The patch is expected to be inline, directly following the message. Any
line that is of the form: 

. three-dashes and end-of-line, or 
. a line that begins with "diff -", or 
. a line that begins with "Index: "
"

Or should the git filter also look for a "scissor-line" [3] to identify a
git-message?

[1] http://www.kernel.org/pub/software/scm/git/docs/git-send-email.html
[2] http://linux.die.net/man/1/git-am 
[3] http://linux.die.net/man/1/git-mailinfo 

Or are there any guaranteed under water git-markers in the mailheader?

-----Oorspronkelijk bericht-----
Van: Robert Mast [mailto:beheerder@tekenbeetziekten.nl] 
Verzonden: woensdag 30 januari 2013 18:15
Aan: 'Carl Worth'; 'Jani Nikula'; 'notmuch@notmuchmail.org'
Onderwerp: RE: Reply all - issue

Thanks for your clear explanation.

The thread-merging and breaking is in the procedure already pointed at by
Jani: (_notmuch_database_link_message() in lib/database.cc.)

Is there a quick way to recognize those git-threads by subject-syntax, or to
reliably tag them to exclude them from subject-breaking?




-----Oorspronkelijk bericht-----
Van: Carl Worth [mailto:cworth@cworth.org] 
Verzonden: dinsdag 29 januari 2013 3:48
Aan: Robert Mast; 'Jani Nikula'; notmuch@notmuchmail.org
Onderwerp: RE: Reply all - issue


Is there any existing thread-breaking? There wasn't the last time I looked
at the code closely, (but admittedly, that was a while ago).

-Carl



Thread: