Re: [PATCH] test: do not hide test_emacs errors

Subject: Re: [PATCH] test: do not hide test_emacs errors

Date: Sat, 12 Nov 2011 19:49:29 +0200

To: David Bremner, Dmitry Kurochkin, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Sat, 12 Nov 2011 09:57:53 -0500, David Bremner <david@tethera.net> wrote:
> On Fri,  1 Jul 2011 06:23:48 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > Do not redirect test_emacs stderr to /dev/null.  Test_emacs uses
> > emacsclient(1) now and it does not print unwanted messages (like
> > those from `message') to stderr.  But it does print useful
> > errors, e.g. when emacs server connection fails, given expression
> > is not valid or undefined function is called.
> 
> Is this patch still relevant now that we use dtach to run the tests?

I think this is. running test_emacs may output useful information in
cases test fails (or when initially failing to launc emacs server).
Normally it doesn't seem to output anything -- and therefore the
redirections to /dev/null are not needed.

> I didn't notice any difference, but maybe I was not supposed to.

Me neither.

> 
> d

Tomi

Thread: