On Thu, Sep 06 2012, Michal Nazarewicz <mpn@google.com> wrote: > From: Michal Nazarewicz <mina86@mina86.com> > > --- By looking the code (by applying this patch and looking more context) it looks good to me. If the commit message provided some explanation and use case *why* this patch is needed a casual reviewer who hasn't desired this feature (possibly by not knowing the benefits :) could understand the need better. Now that we have this bcc in json output when is it shown to the user ? Tomi > notmuch-show.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > Actually, I don't understand why json does not include all the > headers... > > diff --git a/notmuch-show.c b/notmuch-show.c > index 3556293..0b7abf1 100644 > --- a/notmuch-show.c > +++ b/notmuch-show.c > @@ -233,6 +233,13 @@ format_headers_json (sprinter_t *sp, GMimeMessage *message, > sp->string (sp, recipients_string); > } > > + recipients = g_mime_message_get_recipients (message, GMIME_RECIPIENT_TYPE_BCC); > + recipients_string = internet_address_list_to_string (recipients, 0); > + if (recipients_string) { > + sp->map_key (sp, "Bcc"); > + sp->string (sp, recipients_string); > + } > + > if (reply) { > sp->map_key (sp, "In-reply-to"); > sp->string (sp, g_mime_object_get_header (GMIME_OBJECT (message), "In-reply-to")); > -- > 1.7.7.3 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch