Re: [PATCH v4 1/3] Add support for structured output formatters.

Subject: Re: [PATCH v4 1/3] Add support for structured output formatters.

Date: Thu, 12 Jul 2012 13:05:42 +0300

To: craven@gmx.net, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Thu, Jul 12 2012, craven@gmx.net wrote:

> This patch adds a new type sprinter_t, which is used for structured
> formatting, e.g. JSON or S-Expressions. The structure printer is the
> code from Austin Clements (id:87d34hsdx8.fsf@awakening.csail.mit.edu).

...

> +
> +/* Create a new structure printer that emits JSON */
> +struct sprinter *
> +sprinter_json_new(const void *ctx, FILE *stream);
> +
> +/* A dummy structure printer that signifies that standard text output is
> + * to be used instead of any structured format.
> + */
> +struct sprinter *
> +sprinter_text;

Looks good... but this needs to be 'extern struct sprinter * sprinter_text;'

see id:"1340563714-3103-1-git-send-email-tomi.ollila@iki.fi"
for reference.


> +
> +#endif // NOTMUCH_SPRINTER_H
> -- 
> 1.7.11.1

Tomi

Thread: