On Mon, May 04 2020, David Bremner wrote: > In id:1588595993-ner-8.651@TPL520 Franz Fellner reported that tags > starting with 'attachment' are removed by 'notmuch reindex'. This is > probably related to the use of STRNCMP_LITERAL in Haa, I looked this briefly but failed to see it is STRNCMP_LITERAL, not STRCMP_LITERAL (the latter could be optimized strcmp using memcmp w/ constant len) Series LGTM (I'm trying to look away that 'we' passive ;) Tomi > _notmuch_message_remove_indexed_terms. > --- > test/T700-reindex.sh | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/test/T700-reindex.sh b/test/T700-reindex.sh > index 9e795896..7b7e52de 100755 > --- a/test/T700-reindex.sh > +++ b/test/T700-reindex.sh > @@ -33,6 +33,15 @@ notmuch reindex '*' > notmuch dump > OUTPUT > test_expect_equal_file initial-dump OUTPUT > > +test_begin_subtest 'reindex preserves tags with special prefixes' > +test_subtest_known_broken > +notmuch tag +attachment2 +encrypted2 +signed2 '*' > +notmuch dump > EXPECTED > +notmuch reindex '*' > +notmuch dump > OUTPUT > +notmuch tag -attachment2 -encrypted2 -signed2 '*' > +test_expect_equal_file EXPECTED OUTPUT > + > test_begin_subtest 'reindex moves a message between threads' > notmuch search --output=threads id:87iqd9rn3l.fsf@vertex.dottedmag > EXPECTED > # re-parent > -- > 2.26.2 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch _______________________________________________ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch