Re: [PATCH v3 0/5] rst2man.py support and doc-build cleanups

Subject: Re: [PATCH v3 0/5] rst2man.py support and doc-build cleanups

Date: Sun, 13 Jul 2014 09:05:41 +0300

To: W. Trevor King, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Sun, Jul 13 2014, "W. Trevor King" <wking@tremily.us> wrote:

> Changes since v2 [1]:
>
> * In patches 1/5 and 5/5, use for loops to check for rst2man[.py] and
>   rst2html[.py].
> * In patches 1/5 and 5/5, store the command names, not the full paths
>   (command -v …) [2].
> * In patch 3/5, I've added argparse handling to the newly-renamed
>   rst-man2any.py.  Tomi suggested modeling the name and UI on texi2any
>   [3], but texi2any is for converting a single file, while
>   rst-man2any.py is for converting a whole tree (and it takes an
>   arbitrary ReST-to-$x converter to do the real work).  I've basically
>   just cleaned things up, but if folks aren't satisfied I'm going to
>   need more concrete suggestions ;).

The series now looks good to me, I don't have time to test it now but will
do it after Jul 20th.

I am satisfied with rst-man2any.py, but as being normal picky me I wonder
whether the command prefix 'rst-' is being too generic i.e. is invading
that "namespace". If no one else has the same feeling (or the feeling is
just wrong (or insignificant)) then this can be forgotten :D

>
> Cheers,
> Trevor

Thanks, good work!


Tomi

>
> [1]: id:cover.1399740604.git.wking@tremily.us
>      http://thread.gmane.org/gmane.mail.notmuch.general/18291
> [2]: id:m2ion3dn0r.fsf@guru.guru-group.fi
>      http://article.gmane.org/gmane.mail.notmuch.general/18652
> [3]: id:m2lhrzj8kb.fsf@guru.guru-group.fi
>      http://article.gmane.org/gmane.mail.notmuch.general/18653
>
> W. Trevor King (5):
>   doc: Allow rst2man.py as an alternative to rst2man
>   doc/prerst2man.py: Convert execfile to import
>   doc/rst-man2any.py: Adjust to handle any output format, not just man
>     pages
>   doc: Consolidate Makefile targets around {build|install}-{format}
>   doc: Add rst2html support for building HTML docs
>
>  Makefile.local     |  14 ++++++-
>  configure          |  45 ++++++++++++++++++++---
>  doc/INSTALL        |  47 +++++++++++++++++-------
>  doc/Makefile.local |  48 ++++++++++++++----------
>  doc/prerst2man.py  |  63 --------------------------------
>  doc/rst-man2any.py | 105 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 217 insertions(+), 105 deletions(-)
>  delete mode 100644 doc/prerst2man.py
>  create mode 100755 doc/rst-man2any.py
>
> -- 
> 1.9.1.353.gc66d89d
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: