On Tue, 14 Feb 2012 12:33:35 -0500, Austin Clements <amdragon@MIT.EDU> wrote: > The saga continues. As for the text format, this first shifts lots of > code around without changing its semantics, then it dives in and > simplifies a lot of things. Don't be put off by the number of > patches; most of them are straightforward. > > As an added bonus, I documented (!) the JSON format for both show and > search. I got 2 trailing whitespace "errors" when applied (schemata) patches. Emacs MUA works for me. Most json-related tests pass (for me), but I get this: FAIL notmuch-show for message with invalid From --- emacs.10.expected 2012-02-15 14:28:48.000000000 +0000 +++ emacs.10.output 2012-02-15 14:28:48.000000000 +0000 @@ -1,4 +1,4 @@ -"Invalid " (2001-01-05) (inbox) +Invalid From <test_suite@notmuchmail.org> <q> (2001-01-05) (inbox) If this works for others then the problem is in my setup (I have 8 other tests failing for various other reasons) The patch in id:"1329240823-7856-5-git-send-email-amdragon@mit.edu" changes this -- the + line is almost like it was (without that <q>). Maybe the reason is within gmime-2.4.20-1.el5.rf I'm having in this machine -- have to try on another... ...YES. other machine has (self-compiled) gmime 2.4.25 and there I got All 370 tests behaved as expected (2 expected failures). Code LGTM. +1 Tomi --8<----8<----8<----8<----8<----8<-- PS: I'm using code derived from dme's work to get patches. As it was so convenient to get patched moved across machine I'll mention it here -- maybe we get even better ways to do these things in the future: I have in my notmuch emacs configuration file: (defun get-patches () (interactive) (let ((search-terms-list (notmuch-show-get-message-ids-for-open-messages))) (with-temp-file "~/patch" (call-process notmuch-command nil t nil "show" "--format=mbox" (mapconcat 'identity search-terms-list " OR "))) (with-temp-file "~/message-ids" (insert (mapconcat 'identity search-terms-list "\n") "\n")))) This creates ~/patch which contains 'git am' -able mbox file and ~/message-ids for the message id's (if one has use for it). Now I just scp:d the patch file to another machine, git am'd it and started testing.