On Tue, Nov 06 2012, Ethan Glasser-Camp <ethan.glasser.camp@gmail.com> wrote: > Tomi Ollila <tomi.ollila@iki.fi> writes: > >> Added FILE, notmuch_show_params_t and sprinter_t to be >> types when uncrustifying sources. This affect spacing >> when uncrustify is deciding for type declaration instead >> of binary multiplication operation. > > This looks good to me. If you had plenty of time and no more patches to > review, I'd prefer the slightly cleaner English: > > This affects how uncrustify puts spacing around pointers to these types, > since it can parse them as type declarations instead of binary > multiplication operations. > > ... but even suggesting this indicates I've moved past the bike shed and > into somebody else's kitchen. I always appreciate anybody putting effort to translate my scrawls into more cleaner expressions ;D If the change were more important I'd take time to improve the commit message. Like one of our famous contributors have said: "I also don't think we have to be totally obsessive about our commit history." and "I doubt it would make much difference in the grand scheme of things." :D > Ethan Thanks, Tomi