Re: [PATCH] test: Simplify CLEAN list construction

Subject: Re: [PATCH] test: Simplify CLEAN list construction

Date: Tue, 25 Feb 2014 21:30:47 +0200

To: Austin Clements, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Tue, Feb 25 2014, Austin Clements <amdragon@MIT.EDU> wrote:

> Construct as much of the CLEAN list from TEST_BINARIES as possible,
> rather than duplicating this information by hand.
> ---

LGTM. database-test.c is a "library"

Tomi


>  test/Makefile.local | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/test/Makefile.local b/test/Makefile.local
> index 8870ca3..99324ba 100644
> --- a/test/Makefile.local
> +++ b/test/Makefile.local
> @@ -50,11 +50,6 @@ test:	all test-binaries
>  check: test
>  
>  SRCS := $(SRCS) $(smtp_dummy_srcs)
> -CLEAN := $(CLEAN) $(dir)/smtp-dummy $(dir)/smtp-dummy.o \
> -	 $(dir)/symbol-test $(dir)/symbol-test.o \
> -	 $(dir)/arg-test $(dir)/arg-test.o \
> -	 $(dir)/hex-xcode $(dir)/hex-xcode.o \
> +CLEAN += $(TEST_BINARIES) $(addsuffix .o,$(TEST_BINARIES)) \
>  	 $(dir)/database-test.o \
> -	 $(dir)/random-corpus $(dir)/random-corpus.o \
> -	 $(dir)/parse-time $(dir)/parse-time.o \
>  	 $(dir)/corpus.mail $(dir)/test-results $(dir)/tmp.*
> -- 
> 1.8.4.rc3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: