Re: [PATCH 3/6] Unthreaded mode: allow different result format

Subject: Re: [PATCH 3/6] Unthreaded mode: allow different result format

Date: Thu, 27 Feb 2020 22:02:20 +0200

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Thu, Feb 27 2020, Mark Walters wrote:

> It is likely that the user will want a different line format for
> unthreaded mode from tree mode; in particular the thread structure
> graphics are unnecessary in unthreaded mode.
>
> Add a new customisable variable and set it to something sensible.

Looks good to me (I trust Mark the result format is good)

Tomi

> ---
>  emacs/notmuch-tree.el | 27 ++++++++++++++++++++++++++-
>  1 file changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
> index 80b830dd..760eaaec 100644
> --- a/emacs/notmuch-tree.el
> +++ b/emacs/notmuch-tree.el
> @@ -76,6 +76,31 @@ Note the author string should not contain
>    :type '(alist :key-type (string) :value-type (string))
>    :group 'notmuch-tree)
>  
> +(defcustom notmuch-unthreaded-result-format
> +  `(("date" . "%12s  ")
> +    ("authors" . "%-20s")
> +    ((("subject" . "%s")) ." %-54s ")
> +    ("tags" . "(%s)"))
> +  "Result formatting for unthreaded Tree view. Supported fields are: date,
> +        authors, subject, tree, tags.  Tree means the thread tree
> +        box graphics. The field may also be a list in which case
> +        the formatting rules are applied recursively and then the
> +        output of all the fields in the list is inserted
> +        according to format-string.
> +
> +Note the author string should not contain
> +        whitespace (put it in the neighbouring fields instead).
> +        For example:
> +        (setq notmuch-tree-result-format \(\(\"authors\" . \"%-40s\"\)
> +                                             \(\"subject\" . \"%s\"\)\)\)"
> +  :type '(alist :key-type (string) :value-type (string))
> +  :group 'notmuch-tree)
> +
> +(defun notmuch-tree-result-format ()
> +  (if notmuch-tree-unthreaded
> +      notmuch-unthreaded-result-format
> +    notmuch-tree-result-format))
> +
>  ;; Faces for messages that match the query.
>  (defface notmuch-tree-match-face
>    '((t :inherit default))
> @@ -759,7 +784,7 @@ unchanged ADDRESS if parsing fails."
>    ;; We need to save the previous subject as it will get overwritten
>    ;; by the insert-field calls.
>    (let ((previous-subject notmuch-tree-previous-subject))
> -    (insert (notmuch-tree-format-field-list notmuch-tree-result-format msg))
> +    (insert (notmuch-tree-format-field-list (notmuch-tree-result-format) msg))
>      (notmuch-tree-set-message-properties msg)
>      (notmuch-tree-set-prop :previous-subject previous-subject)
>      (insert "\n")))
> -- 
> 2.11.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: