Re: [PATCH v2 0/7] cli: better tooling support for duplicate messages

Subject: Re: [PATCH v2 0/7] cli: better tooling support for duplicate messages

Date: Mon, 10 Jun 2013 18:30:18 +0300

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Sun, Jun 09 2013, Jani Nikula <jani@nikula.org> wrote:

> v2 of id:cover.1368467532.git.jani@nikula.org
>
> The only change is switching to 1-based indexing for --duplicate=N
> option.

The code looks good to me. Mark's comment about showing duplicate file
from another folder than mentioned in query string could be tackled
in manual somehow. 
Also, when you make next version fix the commit message in
id:61ed86f221d65b4dba438cbc2b4c5b77a484a534.1370775663.git.jani@nikula.org
to mention 1-based.

> Jani.

Tomi

BTW: can we track on which machine you're working on by looking
Message-Id:s >;)

>
>
> Jani Nikula (7):
>   cli: add --duplicate=N option to notmuch search
>   test: test notmuch search --duplicate=N
>   man: document notmuch search --duplicate=N
>   cli: add --output=files option to notmuch count
>   test: test notmuch count --output=files
>   man: document notmuch count --output=files
>   NEWS: cli options for improved duplicate message handling
>
>  NEWS                      |   12 +++++++++
>  man/man1/notmuch-count.1  |   10 ++++++-
>  man/man1/notmuch-search.1 |   11 ++++++++
>  notmuch-count.c           |   37 ++++++++++++++++++++++++++
>  notmuch-search.c          |   18 ++++++++-----
>  test/count                |   10 +++++++
>  test/search-output        |   65 +++++++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 156 insertions(+), 7 deletions(-)
>
> -- 
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: