Re: [PATCH v4 0/3] split async json parser into utility function

Subject: Re: [PATCH v4 0/3] split async json parser into utility function

Date: Sat, 27 Oct 2012 15:12:29 +0300

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila

On Sat, Oct 27 2012, Mark Walters <markwalters1009@gmail.com> wrote:

> This is version 4 of this patch set (v3 is at
> id:"1351037602-11157-1-git-send-email-markwalters1009@gmail.com"). It
> splits the async json parser into its own function and moves it to
> lib.
>
> This version is very similar to v3 except that it finished by moving
> the utility function to lib rather than leaving it notmuch.el. It also
> improves some of the docstrings to clarify how the function and
> variables work. I have not gone quite as far as suggested by Ethan as
> these variables are purely for internal use and Austin's code is well
> documented.

Changes look good and tests pass.

Tomi

> Best wishes
>
> Mark
>
>
> Mark Walters (3):
>   emacs: Split out the incremental json parser into its own function
>   emacs: Rename incremental JSON internal variables
>   emacs: Move the incremental JSON parser to notmuch-lib.el
>
>  emacs/notmuch-lib.el |   66 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  emacs/notmuch.el     |   48 +++---------------------------------
>  2 files changed, 70 insertions(+), 44 deletions(-)
>
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: