Re: [PATCH 2/2] completion: complete notmuch insert --folder to maildir folders only

Subject: Re: [PATCH 2/2] completion: complete notmuch insert --folder to maildir folders only

Date: Thu, 01 Jan 2015 14:12:30 +0200

To: David Bremner, Jani Nikula, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila

On Wed, Dec 31 2014, David Bremner <david@tethera.net> wrote:

> Jani Nikula <jani@nikula.org> writes:
>> +	    local path=`notmuch config get database.path`
>> +	    compopt -o nospace
>> +	    COMPREPLY=( $(compgen -d "$path/${cur##folder:}" | \
>> +		sed "s|^$path/||" | grep -v "\(^\|/\)\(cur\|new\|tmp\)$"
>
> I'm a bit confused here. Why is 'folder:' being stripped? Too much
> copy-pasta?

compgen -d wants a directory ?

there seems to be similar strippings done in completion of
notmuch_search_terms.

>
> d

Tomi

PS: if it weren't inconsistent change, just on '#' would suffice ;)

Thread: