Re: [PATCH 4/4] emacs: Simplify and fix `notmuch-mua-prompt-for-sender'

Subject: Re: [PATCH 4/4] emacs: Simplify and fix `notmuch-mua-prompt-for-sender'

Date: Sat, 22 Feb 2014 12:17:24 +0200

To: Austin Clements, notmuch@notmuchmail.org

Cc: bjonnh-nm@bjonnh.net

From: Tomi Ollila


On Thu, Feb 20 2014, Austin Clements <amdragon@MIT.EDU> wrote:

This seris LGTM. I don't know about patch 4 as I have not used
the features (hand-edited From: always...)  maybe I should...

Tomi


> This patch rewrites `notmuch-mua-prompt-for-sender' to simply prompt
> for a full identity, where the list of identities is derived from
> either notmuch-identities or the user's Notmuch configuration.
>
> The original code also did several strange things, like using `eval'
> and specifying that this function was interactive.  As a side-effect,
> this patch fixes these problems.  And it adds a docstring.
> ---
>  emacs/notmuch-mua.el | 33 +++++++++------------------------
>  1 file changed, 9 insertions(+), 24 deletions(-)
>


Thread: