On Sun, Aug 30 2015, David Bremner <david@tethera.net> wrote: > Tomi Ollila <tomi.ollila@iki.fi> writes: > >> +(defsubst notmuch-address--message-insinuated () >> + (memq notmuch-address-message-alist-member message-completion-alist)) >> + > > Is there some advantage to defsubst other than (maybe?) performance? It > just seems like one more construct for people to get up to speed with > the codebase. No advantage. The reason for defsubst may originally be that I did it for least execution chance -- and iirc I was reading some (gnus?) code that had quite a few defsubsts which infected my coding. Now that I checked there is no (other) defsubsts code in notmuch-emacs... so that can be just be changed to `defun' to be consistent in that sense. > > d Tomi