Re: [PATCH 0/4] rename pick to tree

Subject: Re: [PATCH 0/4] rename pick to tree

Date: Sun, 27 Oct 2013 11:42:14 +0200

To: Mark Walters, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila


On Sun, Oct 27 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> This is a non-screwed up (I hope) version of
> id:1382822481-26659-1-git-send-email-markwalters1009@gmail.com
>
> It renames pick to tree (usually called tree view in
> documentation). See the previous cover letter for comments and how I
> have split it.
>
> This time all tests pass at each stage on a fresh clone, and the
> actual move of the notmuch-pick.el file itself to notmuch-tree.el is
> also included.

LGTM. I will test (again) when the series posted to move this mainline
is submitted.

Tomi

> Best wishes
>
> Mark
>
> Mark Walters (4):
>   contrib: pick: move lisp names from pick to tree
>   pick: Change the test names and print out for pick tests
>   pick: rename test outputs from pick to tree
>   pick: rename test emacs-pick to emacs-tree
>
>  contrib/notmuch-pick/notmuch-pick.el               |  951 --------------------
>  contrib/notmuch-pick/notmuch-tree.el               |  951 ++++++++++++++++++++
>  contrib/notmuch-pick/run-tests.sh                  |    4 +-
>  contrib/notmuch-pick/test/emacs-pick               |  210 -----
>  contrib/notmuch-pick/test/emacs-tree               |  210 +++++
>  .../pick.expected-output/notmuch-pick-show-window  |   40 -
>  .../notmuch-pick-single-thread                     |    6 -
>  .../pick.expected-output/notmuch-pick-tag-inbox    |   53 --
>  .../notmuch-pick-tag-inbox-tagged                  |   53 --
>  .../notmuch-pick-tag-inbox-thread-tagged           |   53 --
>  .../tree.expected-output/notmuch-tree-show-window  |   40 +
>  .../notmuch-tree-single-thread                     |    6 +
>  .../tree.expected-output/notmuch-tree-tag-inbox    |   53 ++
>  .../notmuch-tree-tag-inbox-tagged                  |   53 ++
>  .../notmuch-tree-tag-inbox-thread-tagged           |   53 ++
>  15 files changed, 1368 insertions(+), 1368 deletions(-)
>  delete mode 100644 contrib/notmuch-pick/notmuch-pick.el
>  create mode 100644 contrib/notmuch-pick/notmuch-tree.el
>  delete mode 100755 contrib/notmuch-pick/test/emacs-pick
>  create mode 100755 contrib/notmuch-pick/test/emacs-tree
>  delete mode 100644 contrib/notmuch-pick/test/pick.expected-output/notmuch-pick-show-window
>  delete mode 100644 contrib/notmuch-pick/test/pick.expected-output/notmuch-pick-single-thread
>  delete mode 100644 contrib/notmuch-pick/test/pick.expected-output/notmuch-pick-tag-inbox
>  delete mode 100644 contrib/notmuch-pick/test/pick.expected-output/notmuch-pick-tag-inbox-tagged
>  delete mode 100644 contrib/notmuch-pick/test/pick.expected-output/notmuch-pick-tag-inbox-thread-tagged
>  create mode 100644 contrib/notmuch-pick/test/tree.expected-output/notmuch-tree-show-window
>  create mode 100644 contrib/notmuch-pick/test/tree.expected-output/notmuch-tree-single-thread
>  create mode 100644 contrib/notmuch-pick/test/tree.expected-output/notmuch-tree-tag-inbox
>  create mode 100644 contrib/notmuch-pick/test/tree.expected-output/notmuch-tree-tag-inbox-tagged
>  create mode 100644 contrib/notmuch-pick/test/tree.expected-output/notmuch-tree-tag-inbox-thread-tagged
>
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thread: