Re: [PATCH 3/3] configure: make _check_session_keys work with an as-needed linker

Subject: Re: [PATCH 3/3] configure: make _check_session_keys work with an as-needed linker

Date: Tue, 21 May 2019 21:32:28 +0300

To: Notmuch Mail

Cc:

From: Tomi Ollila


On Mon, May 20 2019, David Bremner wrote:

> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>> When using a promiscuous linker, _check_session_keys was working fine.
>>
>
> cleanup series pushed, with one minor change. For reasons that Tomi can
> explain, we use "command -v" instead of "which" in scripts.

command is shell builtin, and all modern shells knows the 

    command -v name >/dev/null construct.

and works similarly, hash is also shell builtin, but in ksh it returns
0 even the name in question is not found. So when someone uses parts of
our shell scripts as an example when they do their own they have better
change of succeeding. which(1) is not shell builtin, usually 
located at /usr/bin.

BR, 

Tomi

>
> d
_______________________________________________
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Thread: