On Sat, 24 Dec 2011 20:06:35 -0500, Austin Clements <amdragon@MIT.EDU> wrote: > Awesome. This looks significantly cleaner. I think this is worth > pushing for the comment you added to notmuch-show-advance alone. Thanks. > This definitely changes the behavior of rewind, but other than one > case I point out below, I think what you have now is much closer to an > inverse of advance. It would be nice to have tests for rewind (looks > like we don't have any right now), but it would seem counterproductive > to write tests for the current rewind only to rewrite them for this > rewind. I'll write some tests. > Tailing whitespace. Will fix. > > + ((= start-of-message (point)) > > + ;; The cursor is at the start of the current message - move to > > + ;; the previous open message. > > + (notmuch-show-previous-open-message)) > > This will jump to the beginning of the previous message if I'm at the > beginning of a message. I would expect rewind to show me the end of > the previous message in this case. That would definitely more closely be the inverse of how advance works, but is it the most useful behaviour?