Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility

Subject: Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility

Date: Thu, 26 Jan 2012 15:04:32 +0000

To: Pieter Praet, Notmuch Mail

Cc:

From: David Edmondson

On Thu, 26 Jan 2012 14:02:15 +0100, Pieter Praet <pieter@praet.org> wrote:
> I may be missing something, but wouldn't both issues be solved by simply
> pressing M-RET a second time?  I've been using this for a little while
> now, and IMO it makes navigating through long and diverging threads a lot
> faster, much like zooming in/out on an outline.
> 
> How about if C-u M-RET behaved as usual ?

Okay, I used it for a day and I'm happy that the original patch is
good.

+2 (which leaves me at +1).

• Previous message (by thread): Re: [PATCH v2 1/7] test: emacs: new tests "notmuch-show: {show, hide} message headers"

Thread:

• Pieter Praet—[PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  • David Edmondson—Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility [inbox, signed, unread]
    • Tomi Ollila—Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility [inbox, unread]
    • Pieter Praet—Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility [inbox, unread]
      • David Edmondson—Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility [inbox, notmuch::review, signed, unread]
  • Tomi Ollila—Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility [inbox, notmuch::review, unread]
  • Dmitry Kurochkin—Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility [inbox, notmuch::review, unread]
    • Pieter Praet—Re: [PATCH] emacs: make `notmuch-show-open-or-close-all' toggle visibility [inbox, unread]
  • Pieter Praet—[PATCH v2 1/7] test: emacs: new tests "notmuch-show: {show, hide} message headers" [inbox, notmuch::patch, notmuch::pushed, notmuch::test, unread]
    • David Bremner—Re: [PATCH v2 1/7] test: emacs: new tests "notmuch-show: {show, hide} message headers" [inbox, unread]
  • Pieter Praet—[PATCH v2 2/7] test: emacs: new tests "notmuch-show: {, un}collapse all messages in thread" [inbox, notmuch::patch, notmuch::pushed, notmuch::test, unread]
  • Pieter Praet—[PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
    • Ethan Glasser-Camp—Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' [inbox, notmuch::review, unread]
      • Ethan Glasser-Camp—Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' [inbox, unread]
        • Tomi Ollila—Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' [inbox, unread]
        • Tomi Ollila—Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' [inbox, unread]
          • Ethan—Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' [inbox, unread]
            • Tomi Ollila—Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' [inbox, unread]
  • Pieter Praet—[PATCH v2 4/7] emacs: rename `notmuch-show-toggle-message' to `notmuch-show-toggle-visibility-message' [inbox, notmuch::emacs, notmuch::patch, notmuch::stale, unread]
  • Pieter Praet—[PATCH v2 5/7] emacs: rename `notmuch-show-open-or-close-all' to `notmuch-show-toggle-visibility-messages' [inbox, notmuch::emacs, notmuch::patch, notmuch::stale, unread]
  • Pieter Praet—[PATCH v2 6/7] emacs: make `notmuch-show-toggle-visibility-messages' live up to its new name [inbox, notmuch::emacs, notmuch::patch, notmuch::stale, unread]
  • Pieter Praet—[PATCH v2 7/7] emacs: `notmuch-show-toggle-visibility-messages' with prefix arg filters by tag [inbox, notmuch::emacs, notmuch::patch, notmuch::stale, notmuch::wip, unread]