Re: [PATCH] test: remove ".sh" extension from the recently added Emacs tests

Subject: Re: [PATCH] test: remove ".sh" extension from the recently added Emacs tests

Date: Sat, 28 Jan 2012 08:08:55 +0000

To: Dmitry Kurochkin, notmuch@notmuchmail.org

Cc:

From: David Edmondson


On Sat, 28 Jan 2012 08:47:39 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> All test files, except for the recently added Emacs tests, do not have
> ".sh" extension.  So remove it from the new test files for consistency.

It's fine with me, though I'll point out that they have .sh because of
id:"87k44r8s0a.fsf@gmail.com":

>   I like the idea of putting elisp testing code into .el files and calling
>   functions from regular tests (that is why I added test-lib.el).  For
>   tests implemented in elisp, I propose adding a pair of files, e.g.:
> 
>     tests/emacs-address.sh - tests that call elisp functions
>     tests/emacs-address.el - elisp code that actually implements the tests
part-000.sig (application/pgp-signature)

Thread: