Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers'

Subject: Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers'

Date: Thu, 18 Oct 2012 09:37:41 -0400

To: Tomi Ollila

Cc: Notmuch Mail, Pieter Praet

From: Ethan


On Thu, Oct 18, 2012 at 5:50 AM, Tomi Ollila <tomi.ollila@iki.fi> wrote:

> On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
>
> > Ethan Glasser-Camp <ethan.glasser.camp@gmail.com> writes:
> >
> >> This patch, and its predecessors, all look great to me.
> >
> > But a note: many of the first lines in your commit messages ("{show,
>
> Hmm, first lines -- IIRC mailman adds those tabs to the subject line -- and
> those are converted to spaces in git-am (??)
>

I guess this is called "line folding" and notmuch should be sure to undo
it, as I guess git-am already does.

https://bugs.launchpad.net/mailman/+bug/265915

I guess I can stop complaining about it ;) Patches 1-3 are probably ready
then. Thanks, Tomi.

Ethan

Thread: