Re: [PATCH v2] emacs: add function to toggle display of all multipart/alternative parts

Subject: Re: [PATCH v2] emacs: add function to toggle display of all multipart/alternative parts

Date: Sun, 24 Jun 2012 10:10:01 +0300

To: David Bremner

Cc: notmuch@notmuchmail.org

From: Jani Nikula


On Jun 23, 2012 1:34 AM, "David Bremner" <david@tethera.net> wrote:
>
> Jani Nikula <jani@nikula.org> writes:
>
> >
> > A small wrinkle is that in order to make the variable survive
> > notmuch-show-refresh-view (which is required for expanding/collapsing
> > the parts, but ends up calling kill-all-local-variables through
> > notmuch-show-mode) it is necessary to give it the permanent-local
> > property.
>
> The code looks simple enough; should we apply this patch while we wait
> for something fancier?

Applying this doesn't make the fancy stuff harder to do at all. And this
doesn't have a key binding, on purpose, so we're not committed to that
either. But then I'm biased...

> I don't really know how to evaluate the
> permanent-local bit.

All the other show mode toggles use that too. It's probably less surprising
like this than the permanently local only as needed approach in v1.

>
> d

Thread: