Re: [PATCH] test:Improve test behaviors when --root is used

Subject: Re: [PATCH] test:Improve test behaviors when --root is used

Date: Mon, 27 Jun 2011 16:50:47 -0400

To: Mark Anderson

Cc: notmuch@notmuchmail.org

From: Austin Clements


This looks great (modulo one bug, below).  I've wanted to run the
tests on tmpfs before, but was too lazy to actually fix the tests.

Given how easy it is to accidentally use "..", I wonder if there's a
way to force people to use $TEST_DIRECTORY?

On Mon, Jun 27, 2011 at 12:09 PM, Mark Anderson <ma.skies@gmail.com> wrote:
> --- a/test/symbol-hiding
> +++ b/test/symbol-hiding
> @@ -12,13 +12,13 @@ test_description='exception symbol hiding'
>  . ./test-lib.sh
>
>  run_test(){
> -    result=$(LD_LIBRARY_PATH=../../lib ./symbol-test 2>&1)
> +    result=$(LD_LIBRARY_PATH=$TEST_DIRECTORY/../../lib ./symbol-test 2>&1)

Did you mean $TEST_DIRECTORY/../lib?

Thread: