[PATCH v2 4/6] nmbug-status: Factor out header/footer context into a shared dict

Subject: [PATCH v2 4/6] nmbug-status: Factor out header/footer context into a shared dict

Date: Sat, 31 May 2014 15:20:25 -0700

To: notmuch@notmuchmail.org

Cc: Tomi Ollila

From: W. Trevor King


Rather than splitting this context into header-only and footer-only
groups, just dump it all in a shared dict.  This will make it easier
to eventually split the header/footer templates out of this script
(e.g. if we want to load them from the config file).
---
 devel/nmbug/nmbug-status | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/devel/nmbug/nmbug-status b/devel/nmbug/nmbug-status
index c92d268..b7c2f80 100755
--- a/devel/nmbug/nmbug-status
+++ b/devel/nmbug/nmbug-status
@@ -275,6 +275,14 @@ parser.add_argument('--get-query', help='get query for view',
 args = parser.parse_args()
 
 config = read_config(path=args.config)
+context = {
+    'date': datetime.datetime.utcnow(),
+    'title': config['meta']['title'],
+    'blurb': config['meta']['blurb'],
+    'encoding': _ENCODING,
+    'inter_message_padding': '0.25em',
+    'border_radius': '0.5em',
+    }
 
 _PAGES['text'] = Page()
 _PAGES['html'] = HtmlPage(
@@ -328,17 +336,13 @@ _PAGES['html'] = HtmlPage(
 {blurb}
 </p>
 <h3>Views</h3>
-'''.format(title=config['meta']['title'],
-           blurb=config['meta']['blurb'],
-           encoding=_ENCODING,
-           inter_message_padding='0.25em',
-           border_radius='0.5em'),
+'''.format(**context),
     footer='''
 <hr>
 <p>Generated: {date}
 </body>
 </html>
-'''.format(date=datetime.datetime.utcnow().date())
+'''.format(**context),
     )
 
 if args.list_views:
-- 
1.9.1.353.gc66d89d


Thread: