Re: [PATCH] cli: factor out config handling code to get/set lists.

Subject: Re: [PATCH] cli: factor out config handling code to get/set lists.

Date: Thu, 12 Jan 2012 18:26:33 +0100

To: David Bremner, Dmitry Kurochkin, notmuch@notmuchmail.org

Cc:

From: Pieter Praet


On Mon, 12 Dec 2011 14:26:21 -0400, David Bremner <david@tethera.net> wrote:
> On Sun, 11 Dec 2011 20:41:53 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > Hi David.
> > 
> > On Sun, 11 Dec 2011 12:07:51 -0400, David Bremner <david@tethera.net> wrote:
> > > From: David Bremner <bremner@debian.org>
> > > 
> > > Two new internal routines are created _config_get_list and
> > > _config_set_list; the notmuch_config_get_* functions that deal with
> > > lists are simply wrappers for these functions.
> 
> Updated version pushed. I'm not completely happy with _config_get_list's
> weird API, but I don't have a better idea now.
> 
> d
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Much cleaner!

However... this would preferrably have been preceded by tests.

Patch follows.


Peace

-- 
Pieter

Thread: