Re: [PATCH] emacs: Remove notmuch-mua-message-send-hook

Subject: Re: [PATCH] emacs: Remove notmuch-mua-message-send-hook

Date: Sat, 19 Sep 2020 06:56:04 -0300

To: Tomi Ollila, Tim Quelch, notmuch@notmuchmail.org

Cc: Tim Quelch

From: David Bremner


Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Sat, Sep 12 2020, Tim Quelch wrote:
>
>> Currently `message-send-hook` functions are being called twice: In
>> notmuch send common when `notmuch-mua-send-hook` functions are
>> run (which by default includes `notmuch-mua-message-send-hook`) and in
>> `message-send` itself.
>>
>> Because `message-send-hook` functions are run in `message-send` itself,
>> we don't need also need to run them before we delegate to `message-send`
>>
>> Calling `notmuch-mua-message-send-hook` resulted in functions in
>> `message-send-hook` to be called twice. This causes bugs in
>> non-idempotent hook functions.
>
> Looks good to me. everyone who rewrote notmuch-mua-message-send-hook
> (i hope none) have to find better solution (or just...)
>

applied to master

d
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: