Re: [PATCH] test:Improve test behaviors when --root is used

Subject: Re: [PATCH] test:Improve test behaviors when --root is used

Date: Tue, 28 Jun 2011 13:28:10 -0700

To: Mark Anderson, Austin Clements, Mark Anderson

Cc: notmuch@notmuchmail.org

From: Carl Worth


On Mon, 27 Jun 2011 17:03:03 -0600, Mark Anderson <MarkR.Anderson@amd.com> wrote:
> On Mon, 27 Jun 2011 15:50:47 -0500, Austin Clements <amdragon@mit.edu> wrote:
> > This looks great (modulo one bug, below).  I've wanted to run the
> > tests on tmpfs before, but was too lazy to actually fix the tests.

Yes, it does look great. Thanks for the patch, Mark!

Did you miss Austin's note about a possible bug? (You quoted it but
didn't reply). See below:

> > >  run_test(){
> > > -    result=$(LD_LIBRARY_PATH=../../lib ./symbol-test 2>&1)
> > > +    result=$(LD_LIBRARY_PATH=$TEST_DIRECTORY/../../lib ./symbol-test 2>&1)
> > 
> > Did you mean $TEST_DIRECTORY/../lib?

If you could follow up with an updated patch, (or an argument that the
original patch is correct), that would be great.

-Carl

-- 
carl.d.worth@intel.com
part-000.sig (application/pgp-signature)

Thread: