Hello. On Mon, 16 Jan 2012 12:21:20 +0000, Jani Nikula <jani@nikula.org> wrote: > On Mon, 16 Jan 2012 15:39:14 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote: > > On Mon, 16 Jan 2012 11:35:37 +0000, David Edmondson <dme@dme.org> wrote: > > > On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote: > > > > Before the change, there were two ways to do search in Emacs UI: > > > > search widget in notmuch-hello buffer and `notmuch-search' > > > > function bound to "s". Internally, notmuch-hello search widget > > > > uses `notmuch-search' function. But it uses widget field input > > > > instead of minibuffer. Such duplication is a major issue for > > > > notmuch-hello usability: search interface is inconsistent and > > > > lacks features that are available in minibuffer (e.g. history and > > > > auto completion). Some of these features may be relatively easy > > > > to implement for notmuch-hello search, others would be much more > > > > tricky. So to avoid duplication, make UI more consistent, bring > > > > notmuch-hello search to feature parity with the minibuffer > > > > search, the patch replaces notmuch-hello search widget and with a > > > > button that works the same way as "s" key binding. > > > > > > Dmitry, if Daniel re-submits his patches to allow the construction of > > > `notmuch-hello' buffers to be configured, it seems that this patchset > > > would become unnecessary. Is that correct? > > > > Right. We will just need to fix the 's' key binding. Looking forward > > for that. > > Isn't (something like) this still needed to merge the search histories: > > id:"1324698436-8532-1-git-send-email-dmitry.kurochkin@gmail.com" > I have sent a new patch series implementing the changes [1]. Regards, Dmitry [1] id:1326828850-8519-1-git-send-email-dmitry.kurochkin@gmail.com > > Jani.